[PR #623]: Acceptance Test PR - Add support for Ubuntu 26.04#628
Draft
span786 wants to merge 1 commit into
Draft
[PR #623]: Acceptance Test PR - Add support for Ubuntu 26.04#628span786 wants to merge 1 commit into
span786 wants to merge 1 commit into
Conversation
Set default OpenJDK to 21 for Ubuntu 26.04 in params.pp Add Ubuntu 26.04 to supported OS releases in metadata.json Extend parameterized tests for Ubuntu 18.04 to include 20.04 and 22.04 (openjdk-11) Add separate tests for Ubuntu 24.04 (openjdk-17) and 26.04 (openjdk-21)
There was a problem hiding this comment.
Pull request overview
Adds module support for Ubuntu 26.04 by updating the default OpenJDK selection logic and extending unit test coverage to validate the expected package/JAVA_HOME behavior across supported Ubuntu releases.
Changes:
- Updated Debian-family release-to-OpenJDK mapping to default Ubuntu 26.04 to OpenJDK 21.
- Added Ubuntu 26.04 to the module’s supported OS list in
metadata.json. - Expanded
javaclass spec coverage for Ubuntu 18.04/20.04/22.04 (OpenJDK 11) and added explicit specs for Ubuntu 24.04 (OpenJDK 17) and 26.04 (OpenJDK 21).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spec/classes/java_spec.rb | Extends rspec-puppet coverage for Ubuntu releases and expected OpenJDK/JAVA_HOME values. |
| metadata.json | Declares Ubuntu 26.04 as a supported OS release. |
| manifests/params.pp | Maps Ubuntu 26.04 to OpenJDK 21 defaults in Debian-family params logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Set default OpenJDK to 21 for Ubuntu 26.04 in params.pp Add Ubuntu 26.04 to supported OS releases in metadata.json Extend parameterized tests for Ubuntu 18.04 to include 20.04 and 22.04 (openjdk-11) Add separate tests for Ubuntu 24.04 (openjdk-17) and 26.04 (openjdk-21)
Related Issues (if any)
PR #623
Checklist
puppet apply)